loader, plugin: load decorated callables only #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
the
Bugfix
dgw
reviewed
Sep 12, 2020
There was a problem hiding this comment.
There's one question in line notes. Besides that, I'm also curious if it would be useful to add the _sopel_callable attribute to the relevant tests in test/test_plugin.py—maybe even some assert not hasattr()s for decorators that aren't supposed to add it? Just a thought. 😸
My initial approach was to test the behaviour of the loader function, more than anything else. After all I decided to add a "protected" attribute (starting with So yeah, I'm still not sure. The behaviour is tested, and I added some corner cases to make sure everything is handled properly. So I feel like it's OK. |
dgw
approved these changes
Sep 14, 2020
Exirel
force-pushed
the
plugin-collect-decorated-callables-only
branch
from
af5b532
to
ad8397c
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #859 and that's it.
Checklist
make qa(runsmake qualityandmake test)