tools, loader, plugins.rules: deprecate compile_rule #2027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #1887.
This is only a draft, because it introduces a major change in
loader.clean_callable
: sincecompile_rule
becomes deprecated, it is not used anymore byloader.clean_callable
. It means that this function doesn't compile patterns anymore. So, even though it doesn't change anything for plugins that don't tinker withloader
themselves (but why would they?), it doesn't generate any change and it should be transparent.The documentation says that
sopel.loader
is for internal purpose, that it may and probably will change without warning, and that the documentation for this module is here for internal dev only. So, technically, it's not a breaking change, because that part of the API is documented as not public.However, if we want to minimize the risk of a plugin relying on internal stuff (again: they should not), I've solutions to deal with that.
@dgw I need your opinion on that one!
Checklist
make qa
(runsmake quality
andmake test
)