Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant return-in-watch #517

Closed
0x009922 opened this issue Mar 13, 2023 · 0 comments · Fixed by #519
Closed

Redundant return-in-watch #517

0x009922 opened this issue Mar 13, 2023 · 0 comments · Fixed by #519
Assignees
@Ctepan
Labels
bug Something isn't working next Related to next lib iteration, i.e. based on Vue 3

Comments

@0x009922
Copy link
Contributor

This:

soramitsu-js-ui-library/packages/ui/src/components/Table/use-table-heights.ts

Lines 57 to 59 in 86086f9

return {
'max-height': maxHeight - headerHeight.value + 'px',
}

watch does not care about callback's return value. This code is probably a bug and should be refactored.
@0x009922 0x009922 added bug Something isn't working next Related to next lib iteration, i.e. based on Vue 3 labels Mar 13, 2023
0x009922 added a commit that referenced this issue Mar 13, 2023
@0x009922
[refactor]: enable noImplicitReturns
2191c40 
New issue: #517

I refactored some stuff in DatePicker with no deep understanding of logic,
but preserving effects (and deleting
unreachable ones)
0x009922 added a commit that referenced this issue Mar 13, 2023
@0x009922
[fix]: refactor heights watcher, close #517
30424e9
@0x009922 0x009922 mentioned this issue Mar 13, 2023
Merged
@0x009922 0x009922 linked a pull request Mar 21, 2023 that will close this issue
[fix] #517: refactor heights watcher #519
Merged
0x009922 added a commit that referenced this issue Mar 21, 2023
@0x009922
Merge pull request #519 from soramitsu/517-table-heights-watch
91752b4 
[fix] #517: refactor heights watcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ctepan Ctepan

Labels
bug Something isn't working next Related to next lib iteration, i.e. based on Vue 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] #517: refactor heights watcher soramitsu/soramitsu-js-ui-library
2 participants
@Ctepan @0x009922