Better TTY logic for zlogin and zlogout #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezintz
added a commit
to ezintz/prezto
that referenced
this pull request
Sep 22, 2016
facastagnini
added a commit
to prezto-inactive-community-fork/prezto
that referenced
this pull request
Dec 29, 2016
|
Hi @leoj3n , your PR got merged in the community maintained fork of this repo. zsh-users is an organization dedicated to host Zsh community projects and therefore became the rational home for a community maintained version of prezto. Your contribution is greatly appreciated! |
|
Thanks for your contribution! What's the advantage of using -o INTERACTIVE over -t 0? It seems like they both accomplish similar goals in different ways (at least in this context). |
|
Nudge @leoj3n |
|
@belak |
ezintz
added a commit
to ezintz/prezto
that referenced
this pull request
Oct 14, 2017
ezintz
added a commit
to ezintz/prezto
that referenced
this pull request
Oct 14, 2017
|
This makes sense. Sorry it's taken me so long to get around to merging it! Is there any reason to check -t 2 as well as -o INTERACTIVE? It seems like checking if the terminal is interactive would be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles more cases more gracefully.