Do not do own logging by default. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since pollon is meant to be used as a reusable package it shouldn't log anything but just return errors. Just for debugging purposes we want to do emit some debug logs. This patch removes the use of capnslog and instead accepts a Logger. Logger is an interface that mimic the stdlib log functions (with only the Print methods). A pollon user can call SetLogger providing a stdlib Logger or a similar logger. By default it'll not log anything.
sgotti
added a commit
that referenced
this pull request
Sep 28, 2016
Do not do own logging by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pollon is meant to be used as a reusable package it shouldn't log
anything but just return errors.
Just for debugging purposes we want to do emit some debug logs.
This patch removes the use of capnslog and instead accepts a Logger. Logger is
an interface that mimic the stdlib log functions (with only the Print methods).
A pollon user can call SetLogger providing a stdlib Logger or a similar logger.
By default it'll not log anything.