Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 #427

Merged
merged 36 commits into from Sep 8, 2021
Merged

v2.0 #427

merged 36 commits into from Sep 8, 2021

Conversation

agoldis
Copy link
Collaborator

@agoldis agoldis commented Aug 26, 2021

v2.0

Breaking changes

  • Deprecated support for cypress agents lt 6.7.0

  • The internal representation of runs has changed. Runs created prior to v2.0 might be displayed partially or not displayed at all.

    • added a progress field on run with the instances and tests progress state. We use this field to report run's progress in hooks / dashboard instead of invoking complex MongoDB queries. This should resolve Webhooks to Github (maybe other hooks) stops reporting back at around 2600 tests #417 because we won't use MongoDB aggregations that create gt 16MB documents.
    • runs.specs will have a short version of "results" - that would allow more efficient data fetching for showing runs feeds and individual runs.

Other changes

@agoldis agoldis changed the title Feat/v2.0 v2.0 Aug 26, 2021
@amitguptagwl
Copy link

I'm planning to use sorry-cypress in my project. I'm wondering if there can be any syntactical change from previous version so I should wait v2.0 to be launched. I'll be using Cypress 8.0.0 or higher in the project.

@agoldis
Copy link
Collaborator Author

agoldis commented Aug 27, 2021

I'm planning to use sorry-cypress in my project. I'm wondering if there can be any syntactical change from previous version so I should wait v2.0 to be launched. I'll be using Cypress 8.0.0 or higher in the project.

The older runs (created prior to 2.0.0) would be partially visible - that's the only visible change I am aware of today. See example at https://sorry-cypress-demo.herokuapp.com/sorry-cypress/runs

You can start using 2.0.0-beta.5 today - it is available via dockerhub:

  • agoldis/sorry-cypress-dashboard:2.0.0-beta.5
  • agoldis/sorry-cypress-director:2.0.0-beta.5
  • agoldis/sorry-cypress-api:2.0.0-beta.5

@amitguptagwl
Copy link

On the speed you're doing the changes, I believe you'll finish the changes soon. Let me wait for a few days. Otherwise I'll start with beta version. Thanks

@KyleThen
Copy link

KyleThen commented Aug 31, 2021

@agoldis FYI, I tried out beta 6 on AWS and was getting some errors in, I think, the director. Sorry I reverted the version change as to not disrupt others so I can't go back and check after I got the screenshot
image

and when trying to actually run Cypress
image

@agoldis
Copy link
Collaborator Author

agoldis commented Aug 31, 2021

@KyleThenTR thanks for discovering that, issued a fix in 2.0.0-beta.8

@KyleThen
Copy link

KyleThen commented Sep 1, 2021

@agoldis things seem to be working well. One question/comment: wondering if the tests that show as Flaky status should be hidden when you toggle the Hide successful specs. Typically when I toggle that, I'm just looking for ones that are in a Failed status

@agoldis
Copy link
Collaborator Author

agoldis commented Sep 1, 2021

@agoldis things seem to be working well. One question/comment: wondering if the tests that show as Flaky status should be hidden when you toggle the Hide successful specs. Typically when I toggle that, I'm just looking for ones that are in a Failed status

Makes sense, will fix

@KyleThen
Copy link

KyleThen commented Sep 2, 2021

@agoldis one other thing kind of related to the Flaky toggle, even though this spec had failed tests, it shows Flaky as the status over Failed. Would think Failed would override Flaky?
image

@agoldis
Copy link
Collaborator Author

agoldis commented Sep 2, 2021

@agoldis one other thing kind of related to the Flaky toggle, even though this spec had failed tests, it shows Flaky as the status over Failed. Would think Failed would override Flaky?
image

Good catch! It is indeed

- Properly show flaky vs passed vs failed
- Update results for tests with exception
@agoldis
Copy link
Collaborator Author

agoldis commented Sep 8, 2021

@KyleThenTR I have published 2.0.0-beta.9

  • hiding flaky when "show only failed tests" switch is on
  • show "failed" even if tests is flaky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment