Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use material ui for layout #444

Merged
merged 2 commits into from Sep 20, 2021
Merged

feat: use material ui for layout #444

merged 2 commits into from Sep 20, 2021

Conversation

ImanMahmoudinasab
Copy link
Contributor

@ImanMahmoudinasab ImanMahmoudinasab commented Sep 13, 2021 •
edited

New feature:

  • Features proposal : 🙏🏻 Help Needed: boldui -> Material-UI #401
  • Describe the use-case in details: it is described in the issue
  • Ensure the solution is backwards-compatible
  • Test it. Submit screenshots / outputs / tests together with the PR.

@ImanMahmoudinasab
Copy link
Contributor Author

Screenshots:

image

@ImanMahmoudinasab
Copy link
Contributor Author

@agoldis Looks like you are pretty busy these days. 😁
I'll start working on other parts of the dashboard after getting your feedbacks on this pr. Also I would update the MUI to v5 which released today.

@agoldis
Copy link
Collaborator

agoldis commented Sep 17, 2021

@agoldis Looks like you are pretty busy these days. 😁
I'll start working on other parts of the dashboard after getting your feedbacks on this pr. Also I would update the MUI to v5 which released today.

Sorry, yes - a bit busy this week. Was hoping to review during the weekend.

@agoldis agoldis merged commit a95e988 into sorry-cypress:master Sep 20, 2021
@ImanMahmoudinasab ImanMahmoudinasab deleted the feat/apply-material-ui-to-layout branch September 20, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ImanMahmoudinasab @agoldis