Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard packages #490

Merged
merged 4 commits into from Nov 14, 2021
Merged

Update dashboard packages #490

merged 4 commits into from Nov 14, 2021

Conversation

ImanMahmoudinasab
Copy link
Contributor

Some of updated packages:

  • "@mui/icons-material": "^5.1.0"
  • "react-router": "^6.0.2"
  • "webpack": "^5.64.0"
  • "webpack-dev-middleware": "^5.2.1"
  • "webpack-dev-server": "^4.5.0"

@agoldis agoldis merged commit 431dd52 into sorry-cypress:master Nov 14, 2021
@fsmaia
Copy link
Contributor

fsmaia commented Dec 13, 2021

This breaks projects with slashes in the name:
https://reactrouter.com/docs/en/v6/upgrading/v5#note-on-route-path-patterns

In react-router v6 there is no way to achieve the old behavior, only encoding the URL, and would get too ugly:
https://cypress.org.com/group%3Fproject%3Fruns, instead of https://cypress.org.com/group/project/runs

Could we revert to react-router v5?

cc @agoldis

@fsmaia fsmaia mentioned this pull request Dec 13, 2021
6 tasks
@ImanMahmoudinasab ImanMahmoudinasab deleted the chore/update-dashboard-packages branch December 14, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants