Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runs query resolver to match schema #61

Merged
merged 1 commit into from Apr 28, 2020
Merged

Fix runs query resolver to match schema #61

merged 1 commit into from Apr 28, 2020

Conversation

xtroncode
Copy link
Contributor

@xtroncode xtroncode commented Apr 27, 2020 •
edited

The query runs returns an error stating Expected Iterable, but did not find one for field Query.runs. as the object returned from the resolver does not match the Query schema. So I fixed the getAllRuns api to use the fullRunReducer instead of the runFeedReducer
fixes #62

@xtroncode xtroncode changed the title Fix runs query reducer to match schema Fix runs query resolver to match schema Apr 27, 2020
@xtroncode xtroncode mentioned this pull request Apr 27, 2020
Closed
@agoldis
Copy link
Collaborator

agoldis commented Apr 27, 2020

Will look into that later today

agoldis
agoldis approved these changes Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@agoldis agoldis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@agoldis agoldis merged commit 3afb86f into sorry-cypress:master Apr 28, 2020
@xtroncode xtroncode deleted the fix-get-all-runs-reducer branch April 28, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agoldis agoldis agoldis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix runs query resolver
2 participants
@xtroncode @agoldis