Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates and Durrations #89

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Conversation

jhicken
Copy link
Collaborator

@jhicken jhicken commented Jul 20, 2020

Adds dates durations and times to runs and instances in most places. It also adds some icons to the overall run summay card. And spec list table.#87

Screen Shot 2020-07-20 at 10 09 03 AM
Screen Shot 2020-07-20 at 10 06 38 AM
Screen Shot 2020-07-20 at 9 52 09 AM

…It also adds some icons to the overall run summay card. And spec list table.
icon="timesOutline"
size={1}
/>
{spec.results.stats.pending}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt look into this but its super odd that the pending stat is actually used for skipped.

return (
<Tooltip text={`Started at ${spec.claimedAt}`}>
<Text>
<RenderOnInterval live refreshIntervalInSeconds={1} renderChild={()=>{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the durration on the page update every second until tests have completed.

Copy link
Collaborator

@agoldis agoldis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @jhicken! Very solid and elegant work 👾👍🏻
I have added few cosmetic changes mostly related to typedefs.

Thank you very much!

@agoldis agoldis merged commit ece0b93 into sorry-cypress:master Jul 21, 2020
@jhicken jhicken deleted the dates-durrations-times branch July 21, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants