-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dates and Durrations #89
Conversation
…It also adds some icons to the overall run summay card. And spec list table.
icon="timesOutline" | ||
size={1} | ||
/> | ||
{spec.results.stats.pending} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didnt look into this but its super odd that the pending stat is actually used for skipped.
return ( | ||
<Tooltip text={`Started at ${spec.claimedAt}`}> | ||
<Text> | ||
<RenderOnInterval live refreshIntervalInSeconds={1} renderChild={()=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the durration on the page update every second until tests have completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @jhicken! Very solid and elegant work 👾👍🏻
I have added few cosmetic changes mostly related to typedefs.
Thank you very much!
Adds dates durations and times to runs and instances in most places. It also adds some icons to the overall run summay card. And spec list table.#87