Please remove external fonts #367
Comments
|
So I looked into this and couldn't find anything with as simple attribution terms as font awesome. As far as I can tell, we don't need to do anything extra currently with font awesome, as we just use the CSS file they give us. It would get complicated to need to add some attribution text along with each icon we use if we use another source, and most other places seem to have fairly strict requirements for the way attribution should be given. I'm going to leave this open in case anyone has thoughts (/tell me I'm wrong because I'm not too confident about the attribution stuff!) on what we could do, as it would be pretty nice to store these icons as an SVG in the CSS or the |
|
You got me wrong. I didn't ask about attribution – but about not using "external fonts" if possible. They act like trackers. Which is why uBlock Origin by default disables them. |
|
Sorry, should have explained better! To not use an external font like
fontawesome, I'd need to get the icons from elsewhere, however I couldn't
find a similar source that has similar attribution terms as font awesome!
…On Mon, 5 Nov 2018, 14:51 Izzy ***@***.*** wrote:
You got me wrong. I didn't ask about attribution – but about not using
"external fonts" if possible. They act like trackers. Which is why uBlock
Origin by default disables them.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#367 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIcNjl1tw7WahjAvLaGOettkdrJ4CQNqks5usFCEgaJpZM4XEZdi>
.
|
|
Language Barrier 😃 That wouldn't solve the "remote font" issue. Well, no idea what would be the most privacy friendly "remote font" source … So maybe we put this issue on ice until we find the answer. Works without enabling remote fonts, though it looks a bit weird then 😉 Just wondered what Github uses: it's inline SVGs (e.g. the icons on the editor). Might be an option as well, and would even load faster (I sometimes see pages stall on contacting FontAwesome or other external resources). |
|
Inline SVGs would be perfect! However I can't find a place to actually get the SVGs to use that have a similar attribution policy! |
|
How many characters/symbols do you need? Maybe someone could simply create them, e.g. by a given screenshot/hand-drawing? E.g. the "scroll-to-top" should be easy enough, just 4 strokes. Not that I could volunteer (I'm not good at graphics), just naming options. |
|
@IzzySoft I think it'd be:
(possible more I haven't thought of) So it wouldn't be an easy task 😝. If you know of any websites that do SVG icons please let me know! I really would like to have the icons contained within SOX if there was a site that wouldn't make it too much harder! |
|
Unfortunately I don't know such a site. But most of what you listed should be pretty generic, so maybe things like the wrench or a search icon can already be found as SVG. Trouble might be to find a "matching set" … Pointer: CC search (so yes, definitely a bunch of search glasses are there in SVG format 😉) |
|
Font Awesome 5 includes SVG icons. |
|
@j-f1 they still want you to load them via Javascript from their site – which is what this issue asks to avoid. Not just for privacy reasons (to avoid tracking), but also for performance. If you load stuff from too many external sources (i.e. more than none 😉) you always run the risk one of them will stall loading the page. And I see this quite often on SE for FontAwesome and some other CDNs. |
|
@IzzySoft There’s an option to download all the SVGs. |
|
Ah, that's good then – provided one is free to use them and "credits" in the source header are sufficient. |
This is part of #367 to remove external fonts. The aim is to stop using FontAwesome and instead only include the icons SOX uses. Advantages: - 'remote fonts' like FontAwesome aren't needed, so some extensions/content blockers like uBlock Origin won't block the icons from appearing - a slight bandwidth usage improvement. Remote fonts load many more icons than SOX needs, so maintaining a single sprite file would mean we only load the ones we need
This is part of #367 to remove external fonts. The aim is to stop using FontAwesome and instead only include the icons SOX uses. These icons are from Google's Material Icons: https://material.io/tools/icons/ Advantages: - 'remote fonts' like FontAwesome aren't needed, so some extensions/content blockers like uBlock Origin won't block the icons from appearing - a slight bandwidth usage improvement. Remote fonts load many more icons than SOX needs, so maintaining a single sprite file would mean we only load the ones we need
|
Sure I still use it – and thanks! Just updated – and now the icon
stack trace 1: stack trace 2: Say what, please? Now that I'm finished copy-pasting those details over, the cog/wheel icon shows up in the MultiCollider™? Wow… OK, so it works now nevertheless 🤣 Thanks a lot! Not sure what those errors refer to then, so I leave them in here. |
|
Great! Glad it's working :) I can see where the first error is coming from, and it is unrelated to this, probably one specific feature. I'll have a look and try getting that fixed (it's an FF-only bug as far as I can tell!) For the second one, it does seem unrelated as well, but is definitely a bug. It seems like there's some API call that's failing and sending a bad response. Please could you check the 'network' tab in the dev tools window (should be next to 'console') and look for any requests that are in red? That should (hopefully) help me narrow down which feature is failing! Alternatively, are there any feature names in red in the SOX settings dialog? If a SOX feature fails to load, the entry in the settings dialog should also turn red! |
|
No red ones. And I doubt it's one of those still blocked (i.e. not explicitly whitelisted) in uMatrix: no reason why you would call out to googletagservices.com, quantserve.com, scorecardresearch.com … wait, there's one 400 response from Before you ask: yes, logged in I am. Several items in SOX configuration are disabled – and it seems my access token got invalidated. I didn't yet request a new one in case you want me to check something else – if you don't, I would try that and see if the second error disappears. Of course that would make it harder testing how a "fixed version" behaves in this context; I'm pretty sure it's related to the token. |
|
Thanks for looking into it! Yeah it will be an access token issue then. Annoyingly, I had added some logic in a while ago to detect an access token going wrong. Could you check to see if there's a You should have got an alert saying |
|
There isn't. Just the relevant items are grayed out and give the hint "you must get an access token to enable this feature" on mouse-over. Oh, in the console, sorry… wait a sec… funny. Not a single error in the console anymore (when on profile page). Let me check another page… OK, on a question page the errors are still shown. But still no "Access token invalid…" hint. Not even with debugging enabled, sorry. And no alert either, no. Shall I simply request a new token – or "stand by" for some more debugging? I don't mind either way. Just let me know when you want to "give it up" 😉 |
|
Urgh, that's annoying. I think you can just request a new token for now 😛 I will try debugging this soon, but unfortunately won't have time in the next few days! |
Installed Version: 2.3.8 DEV Environment: undefined
Current Behaviour
SOX uses a "remote font" for the item in the MetaCollider™ toolbar ("soxSettingsButton"). I refuse to enable remote fonts, as according to uBlock Origin some are loaded from Google, others from FontAwesome (couldn't find a reference in your code, though – so that could be from some SE code) – which makes it look strange (a box for "unknown character"). Just found it with FF's "inspect element": the font used is "Font Awesome 5 Free".
Could you use a local font source for that, to make the script more privacy-friendly (remove a possible tracker)? Same issue for the "jump to top" floating button, btw.
SOX Errors logged to the browser console -- F12 (if available)
Steps to reproduce
Features Enabled
The text was updated successfully, but these errors were encountered: