Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two-directional arrows for links to here that are also linked from here #40

Closed
catb0t opened this issue Apr 5, 2016 · 6 comments
Closed

Comments

@catb0t
Copy link

catb0t commented Apr 5, 2016

Wthout having read the source, my guess is that the "Linked-arrow-direction-generator" function that serves to supply the icons in the "Linked" section uses a process of elimination: the function looks for links that are both in the "Linked" section and on this page, and considers "Linked" entries not on this page to be links-to-here.
If that is indeed the implementation, then this feature-request may or may not warrant a rewrite of that.

Question A links to question B. Question B links to question A. The Lemmings arrows in the "Linked" section for question A will likely show that question B is linked by here and similarly for question B, for the reasons noted in the previous paragraph.

This is, as I've just demonstrated, rather confusing. Could SOX use some form of black magic to detect this recursion and show both arrows in this case?

@shu8
Copy link
Member

shu8 commented Apr 6, 2016

@catb0t your guess is completely right... so this would require a bit of a change, but not too much.. I could $.get() the page and look for the link to the current page.

So, yeah, I should be able to do this! :) (when we get the other issue sorted)

@shu8 shu8 self-assigned this Apr 6, 2016
@shu8 shu8 added this to the v1.0.4 milestone Apr 6, 2016
@shu8
Copy link
Member

shu8 commented Apr 6, 2016

ok... this isn't going to be as easy as I thought it would... so, it'll happen, but not today :(

shu8 added a commit that referenced this issue Apr 16, 2016
shu8 added a commit that referenced this issue Apr 16, 2016
@shu8
Copy link
Member

shu8 commented Apr 16, 2016

@catb0t I've added this now. Please can you install the latest DEV version and confirm it is working for you?

Also, any ideas on how it should look? It looks like this right now...

this

@enki-code ?^^

@mezmi
Copy link
Contributor

mezmi commented Apr 16, 2016

@shu8 Yeah! That'll work! 👍

@shu8 shu8 changed the title Feature request: two-directional arrows for links here that are also linked-by-here Two-directional arrows for links to here that are also linked from here Apr 16, 2016
@catb0t
Copy link
Author

catb0t commented Apr 17, 2016

This is the most beautiful thing I've ever seen. You guys need a big fat donate button...

@catb0t catb0t closed this as completed Apr 17, 2016
@mezmi mezmi removed the ready label Apr 17, 2016
@mezmi
Copy link
Contributor

mezmi commented Apr 17, 2016

@catb0t Just having you say things like that and using the script is enough for me. I really appreciate it.

@shu8 shu8 added confirmed and removed approved labels Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants