'make deps' fails due to undefined Asset in api.go

[stevencothren]

Hello,
I get the following error when trying to run 'make deps' on a fresh checkout.

go get

github.com/pgweb

./api.go:27: undefined: Asset
./api.go:156: undefined: Asset
make: *** [deps] Error 2

The issue is that Asset doesn't get defined until after running 'go-bindata ...' to generate the bindata.go file.

If you include the bindata.go that is generated from 'go-bindata -debug ...' in your project then everything will work and subsequent calls to 'make dev' or 'make build' will overwrite as expected.

Alternatively, you could include the 'go-bindata ... ' call as part of 'make deps', but then 'go get' will need to move down the chain.

[sosedoff]

@stevencothren check master, i made a tweak to the makefile, it should not fail on fresh checkout now.

[stevencothren]

Ok. This is the change I made previously here : #3
It was pointed out there that this change results in the repository still not being 'go get"-able.

I see now that you replied there too.

Is there no way to resolve both issues? Just curious

[sosedoff]

thats alright for now

—
Sent from Mailbox

On Fri, Oct 24, 2014 at 9:06 PM, Steven Cothren notifications@github.com
wrote:

Ok. This is the change I made previously here : #3

It was pointed out there that this change results in the repository still not being 'go get"-able.

Reply to this email directly or view it on GitHub:
#2 (comment)

[stevencothren]

It actually looks like the absolute paths are only included when go-bindata is run with -debug option.

What do you think about including the non-debug version in the repository?

Alternatively, I have been looking at adding an option to go-bindata to use relative paths, which would mean you could include the debug version along with that option.

Thoughts?

[sosedoff]

Im not sure about release assets being included in the repo, feels like duplication to me. Compiling
assets is only required for development purposes, people can download binary releases for general purpose usage in this case and they don't have to compile anything at all. For local development you'll have to install all dependencies anyway.

I'm okay with updated go-bindata package that can support non-absolute paths in the bindata.go file.