Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added copy as insert and copy as update #658

Closed
wants to merge 1 commit into from
Closed

Conversation

jonaz
Copy link

@jonaz jonaz commented Feb 28, 2023

Fixes #649

@jonaz jonaz force-pushed the master branch 2 times, most recently from 59b43e2 to fedcc6a Compare February 28, 2023 21:51
static/js/app.js Show resolved Hide resolved
static/js/app.js Show resolved Hide resolved
static/js/app.js Show resolved Hide resolved
@jonaz
Copy link
Author

jonaz commented May 5, 2023

@sosedoff updated the commit with requested changes. Also make error when table is not selected. Could not find another way to figure out the table name.

@jonaz
Copy link
Author

jonaz commented Jun 28, 2023

Ping @sosedoff ?

@sosedoff
Copy link
Owner

This looks good so far. One thing that may need to be addressed -- context menu does not work correctly when in query editor. Steps to reproduce:

  1. Refresh pgweb page
  2. Go to sql editor and run a query that returns some results
  3. Right click on one of the rows - select copy as insert (will complain about table, thats expected)
  4. Click on any table in the sidebar, it should render its contents
  5. Navigate back to the sql editor, run the existing query again.
  6. Right click on one of the rows - it will incorrectly copy insert statement using previously selected tables.

Id suggest we disable the context menu options on sql query results page.

@a-patos
Copy link

a-patos commented Dec 15, 2023

Hello,
is there any hope that MR will be successful one day or do we move on?

@sosedoff
Copy link
Owner

Closing for the time being. Im happy to revisit if OP is interested in continuing the work.

@sosedoff sosedoff closed this Mar 15, 2024
@jonaz
Copy link
Author

jonaz commented Mar 15, 2024

Yes im interested @sosedoff

@jonaz
Copy link
Author

jonaz commented Apr 10, 2024

New PR here #730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: Copy row result as sql
3 participants