fix: Fix Logo size and title tag - Issue team-GIFT#71

- Fix with problem with height and width - Improuve accessibility with title tag
sosoYim · Jan 18, 2022 · f05994b · f05994b
1 parent c051225
commit f05994b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/components/Logo/Logo.tsx b/src/components/Logo/Logo.tsx
@@ -7,7 +7,7 @@ const transition = {
   ease: 'easeInOut',
 };
 
-export function Logo({ height = '100%', width = '100%' }: LogoProps) {
+export function Logo({ height, width, title }: LogoProps) {
   return (
     <MotionConfig transition={transition}>
       <motion.svg
@@ -17,6 +17,7 @@ export function Logo({ height = '100%', width = '100%' }: LogoProps) {
         xmlns="http://www.w3.org/2000/svg"
         initial="hidden"
       >
+        <title>{title}</title>
         <g id="LogoImage">
           <motion.path
             d="M20 16H0V164H20V16Z"

diff --git a/src/components/Logo/Logo.types.ts b/src/components/Logo/Logo.types.ts
@@ -1,4 +1,5 @@
 export interface LogoProps {
+  title: string;
   height?: number | string;
   width?: number | string;
 }