[docker] docker_cmd on Ubuntu is 'docker.io' ???

[karstengr]

In docker.py https://github.com/sosreport/sos/blob/master/sos/plugins/docker.py#L117 for Ubuntu the docker command is set to 'docker.io'. Not sure if this is true, on my Ubuntu installation the binary is named 'docker'. Can you explain where this comes from?

Btw: the 'docker' package on Ubuntu (System tray for KDE3/GNOME2 docklet applications) contains a binary named 'wmdocker'.

class UbuntuDocker(Docker, UbuntuPlugin):

    packages = ('docker.io', 'docker-engine')

    # Name collision with another package requires docker binary rename
    docker_cmd = 'docker.io'

[pmoravec]

That was introduced by @battlemidget in e63e8af - shall the binary name be docker instead?

[bmr-cymru]

As @pmoravec said, it comes from here:

commit e63e8af401a721899955ff797de78220cbcb8476
Author: Adam Stokes <adam.stokes@ubuntu.com>
Date:   Mon Aug 11 10:47:48 2014 -0400

    [docker] capture logs of running containers, add ubuntu support
    
    Query `docker ps` and capture log output from current running containers.
    Additionally, add support for Ubuntu systems and address a nuance where Ubuntu
    systems use a different binary name for docker since a previous package already
    owns the docker binary name.
    
    Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>

If this is no longer correct (or never was), we're happily accepting suggestions or pull requests.

[slashdd]

Looking in debian/changelog for package "docker.io" in Ubuntu Xenial/16.04 (LTS)... /usr/bin/docker.io symlink has been removed in favour of /usr/bin/docker.

Removing the following lines (which seems to be a workaround, no longer needed) in the docker.py should suffice :
# Name collision with another package requires docker binary rename
docker_cmd = 'docker.io'

Ubuntu | debian/changelog
docker.io (1.3.1~dfsg1-2) unstable; urgency=medium
* Remove deprecated /usr/bin/docker.io symlink
- added as a temporary shim in 1.0.0~dfsg1-1 (13 Jun 2014)
- unused by package-installed files in 1.2.0~dfsg1-1 (13 Sep 2014)
-- Tianon Gravi <admwiggin@gmail.com> Fri, 07 Nov 2014 13:11:34 -0700

[davecore82]

This is fixed by #1009