Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker] Update Ubuntu copy spec #1009

Merged
merged 1 commit into from May 31, 2017
Merged

[docker] Update Ubuntu copy spec #1009

merged 1 commit into from May 31, 2017

Conversation

clnperez
Copy link
Contributor

The binary name changed from docker.io to docker.
Update config and log file locations.

Signed-off-by: Karsten Graul kgraul@linux.vnet.ibm.com
Signed-off-by: Christy Perez christy@linux.vnet.ibm.com

@clnperez
[docker] Update Ubuntu copy spec
f8a939d 
The binary name changed from docker.io to docker.
Update config and log file locations.

Signed-off-by: Karsten Graul <kgraul@linux.vnet.ibm.com>
Signed-off-by: Christy Perez <christy@linux.vnet.ibm.com>
@clnperez
Copy link
Contributor Author

cc/ @karstengr

@adam-stokes
Copy link

@clnperez What Ubuntu releases contain this change? And is it an Ubuntu archive or Docker's upstream archive?

@adam-stokes adam-stokes self-requested a review May 16, 2017 21:16
@karstengr
Copy link

karstengr commented May 17, 2017 •
edited

@battlemidget docker.io was an Ubuntu specific rename due to a conflict with an existing package. In 2014 the package and the command were renamed to docker. See https://bugs.launchpad.net/ubuntu/+source/docker.io/+bug/1338768 :

Note that the docker.io command has been renamed to docker inline with upstream packages; the conflicting Debian binary from the docker package has been renamed wmdocker; this update has already been sru'ed to 14.04.
...
Fix Released 2014-09-04

@adam-stokes
Copy link

@karstengr perfect, thanks for the references.

@adam-stokes adam-stokes mentioned this pull request May 30, 2017
Closed
@adam-stokes
Copy link

@slashdd @davecore82 have a look at this PR and if you feel this covers what we need give it a plus one and I'll get it merged soon.

@adam-stokes adam-stokes merged commit 6594ee1 into sosreport:master May 31, 2017
@davecore82
Copy link
Contributor

davecore82 commented May 31, 2017 •
edited

👍

@slashdd
Copy link

slashdd commented May 31, 2017

👍 for me as well.

@davecore82 davecore82 mentioned this pull request Jun 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-stokes adam-stokes adam-stokes approved these changes

Assignees
No one assigned
Labels
Needs second ACK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@clnperez @adam-stokes @karstengr @davecore82 @slashdd