Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcp] collect 12 newest pmlogger files regardless of size #1496

Conversation

pmoravec
Copy link
Contributor

@pmoravec pmoravec commented Dec 3, 2018

To prevent pmlogger binary files to be truncated and to collect
reasonable count of the files (configurable via pcp.pmloggerfiles
plugin option).

Resolves: #1496

Signed-off-by: Pavel Moravec pmoravec@redhat.com


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?

@pmoravec pmoravec force-pushed the sos-pmoravec-pcp-pmlogger-newest-untruncated-files branch from 190415b to 8fed769 Compare December 3, 2018 09:35
pmoravec added a commit to pmoravec/sos that referenced this pull request Dec 3, 2018
To prevent pmlogger binary files to be truncated and to collect
reasonable count of the files (configurable via pcp.pmloggerfiles
plugin option).

Resolves: sosreport#1496

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
- collect reasonable count of pmlogger files instead of sizelimit
 - (configurable via pcp.pmloggerfiles plugin option
- prevent pmlogger/pmmgr binary files to be truncated/tailed

Resolves: sosreport#1496

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
@pmoravec pmoravec force-pushed the sos-pmoravec-pcp-pmlogger-newest-untruncated-files branch from 8fed769 to 5228cf8 Compare December 10, 2018 07:52
@pmoravec
Copy link
Contributor Author

Updated the PR to not tailing pmmgr logfiled.

There is another request to increase sizelimit of ${PCP_LOG_DIR}/pmmgr/$(hostname) directory from 100MB to 7GB that I have doubts on overall impact (more valuable data collected but for the price of longer sosreport runs and potentially out of diskspace on temp lvolume).

Any thoughts or opinion on the sizelimit increase (cc @bmr-cymru , @mbaldessari , @TurboTurtle , @sandrobonazzola )?

@pmoravec
Copy link
Contributor Author

Updated the PR to not tailing pmmgr logfiled.

There is another request to increase sizelimit of ${PCP_LOG_DIR}/pmmgr/$(hostname) directory from 100MB to 7GB that I have doubts on overall impact (more valuable data collected but for the price of longer sosreport runs and potentially out of diskspace on temp lvolume).

Any thoughts or opinion on the sizelimit increase (cc @bmr-cymru , @mbaldessari , @TurboTurtle , @sandrobonazzola )?

Please disregard, no such requirement for pmmgr is requested.

What is required and the PR solves:

  • from pmlogger, collect 12 newest files of whatever size (this might cause disk space issues if the files are huge, but let try now)
  • from pmmgr, collect up to 100MB of logfiles and dont tail the "file just over limit"

@bmr-cymru bmr-cymru closed this in dbb76f0 Mar 12, 2019
@bmr-cymru bmr-cymru added this to the 3.7 milestone Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants