Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[landscape] Substitute oidc conf in service file #2025

Closed
wants to merge 1 commit into from
Closed

[landscape] Substitute oidc conf in service file #2025

wants to merge 1 commit into from

Conversation

slashdd
Copy link

@slashdd slashdd commented Apr 16, 2020

Substitute sensitive informations about oidc
found in landscape service configuration file.

From release 19.10, Landscape can use OpenID-Connect
(OIDC) to authenticate users. To enable OpenID-Connect
support, please add oidc-issuer, oidc-client-id and
oidc-client-secret to /etc/landscape/service.conf in
the [landscape] section.

Reference:
https://docs.ubuntu.com/landscape/en/onprem-auth#openid-connect-support

Resolves: #2023

Signed-off-by: Eric Desrochers eric.desrochers@canonical.com


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • If this commit closes an existing issue, is the line Closes: #ISSUENUMBER included in an independent line?
  • If this commit resolves an existing pull request, is the line Resolves: #PRNUMBER included in an independent line?

Substitute sensitive informations about oidc
found in landscape service configuration file.

From release 19.10, Landscape can use OpenID-Connect
(OIDC) to authenticate users. To enable OpenID-Connect
support, please add oidc-issuer, oidc-client-id and
oidc-client-secret to /etc/landscape/service.conf in
the [landscape] section.

Reference:
https://docs.ubuntu.com/landscape/en/onprem-auth#openid-connect-support

Resolves: #2023

Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging shortly.

@TurboTurtle
Copy link
Member

Closed via 6bb699d - timing of the push hit during a GH outage which prevented the auto close triggers from firing.

TurboTurtle pushed a commit to TurboTurtle/sos that referenced this pull request Apr 22, 2020
Substitute sensitive informations about oidc
found in landscape service configuration file.

From release 19.10, Landscape can use OpenID-Connect
(OIDC) to authenticate users. To enable OpenID-Connect
support, please add oidc-issuer, oidc-client-id and
oidc-client-secret to /etc/landscape/service.conf in
the [landscape] section.

Reference:
https://docs.ubuntu.com/landscape/en/onprem-auth#openid-connect-support

Closes: sosreport#2023
Resolves: sosreport#2025

Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landscape plugin should protect oidc secrets
3 participants