Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landscape plugin should protect oidc secrets #2023

Closed
cjohnston1158 opened this issue Apr 16, 2020 · 3 comments
Closed

Landscape plugin should protect oidc secrets #2023

cjohnston1158 opened this issue Apr 16, 2020 · 3 comments

Comments

@cjohnston1158
Copy link
Contributor

Landscape has added the ability to connect to OIDC. The plugin should be updated to obfuscate the sensitive information.

https://docs.ubuntu.com/landscape/en/onprem-auth#openid-connect-support
@slashdd
Copy link

slashdd commented Apr 16, 2020

@cjohnston1158 thanks, I'm on it.

@slashdd slashdd mentioned this issue Apr 16, 2020
Closed
6 tasks
@slashdd
Copy link

slashdd commented Apr 16, 2020

@simpoir fyi

@TurboTurtle
Copy link
Member

Closed via 6bb699d - timing of the push hit during a GH outage which prevented the auto close triggers from firing.

TurboTurtle pushed a commit to TurboTurtle/sos that referenced this issue Apr 22, 2020
@TurboTurtle
[landscape] Substitute oidc conf in service file
6bb699d 
Substitute sensitive informations about oidc
found in landscape service configuration file.

From release 19.10, Landscape can use OpenID-Connect
(OIDC) to authenticate users. To enable OpenID-Connect
support, please add oidc-issuer, oidc-client-id and
oidc-client-secret to /etc/landscape/service.conf in
the [landscape] section.

Reference:
https://docs.ubuntu.com/landscape/en/onprem-auth#openid-connect-support

Closes: sosreport#2023
Resolves: sosreport#2025

Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[landscape] Substitute oidc conf in service file
3 participants
@TurboTurtle @slashdd @cjohnston1158