Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpm] Capture the output of 'rpm --showrc' #2388

Closed
wants to merge 1 commit into from
Closed

[rpm] Capture the output of 'rpm --showrc' #2388

wants to merge 1 commit into from

Conversation

jcastill
Copy link
Member

@jcastill jcastill commented Jan 28, 2021

This request adds the output of --showrc to sos
so we can verify the default values of options set
via rpmrc and macros config files.

Resolves: RHBZ#1921496
Resolves: #2388

Signed-off-by: Jose Castillo jcastillo@redhat.com


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • If this commit closes an existing issue, is the line Closes: #ISSUENUMBER included in an independent line?
  • If this commit resolves an existing pull request, is the line Resolves: #PRNUMBER included in an independent line?

("rpmdb", "collect /var/lib/rpm", "slow", False)]
("rpmdb", "collect /var/lib/rpm", "slow", False),
("rpmshowrc", "shows the options in rpmrc and macros files",
"fast", True)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need to be gated behind a plugin option? We usually reserve those options for long running items, potentially sensitive collections, or historically ones that could make changes to the system (before the addition of --allow-system-changes and the like).

From quick testing this looks like it should be safe for a default collection.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree that the extra option (though enabled by default) is bit redundant - I cant figure out a use case when one would need to prevent collecting the cmdoutput.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose this approach to make sure that it was consistent with the other options, but you are right, so let me re-send this PR.

This request adds the output of --showrc  to sos
so we can verify the default values of options set
via rpmrc and macros config files.

Resolves: RHBZ#1921496

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants