[pylint] pylint and flake8 updates #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
arif-ali
force-pushed
the
sos-arif-pylint-c0411
branch
from
dd2bd29
to
35e46cc
Compare
arif-ali
added a commit
to arif-ali/sos
that referenced
this pull request
Apr 16, 2024
pylint for the following rules applied * C0411: wrong-import-order * R0912: too-many-branches * R0914: too-many-locals * R1725: super-with-arguments * E1101: no-member Resolves: sosreport#3597 Signed-off-by: Arif Ali <arif.ali@canonical.com>
arif-ali
force-pushed
the
sos-arif-pylint-c0411
branch
from
35e46cc
to
f591230
Compare
arif-ali
added a commit
to arif-ali/sos
that referenced
this pull request
Apr 21, 2024
pylint for the following rules applied * C0411: wrong-import-order * R0912: too-many-branches * R0914: too-many-locals * R1725: super-with-arguments * E1101: no-member Resolves: sosreport#3597 Signed-off-by: Arif Ali <arif.ali@canonical.com>
arif-ali
force-pushed
the
sos-arif-pylint-c0411
branch
from
f591230
to
8c68bfd
Compare
pylint for the following rules applied * C0411: wrong-import-order * R0912: too-many-branches * R0914: too-many-locals * R1725: super-with-arguments * E1101: no-member Resolves: sosreport#3597 Signed-off-by: Arif Ali <arif.ali@canonical.com>
arif-ali
force-pushed
the
sos-arif-pylint-c0411
branch
from
8c68bfd
to
ec53ec5
Compare
arif-ali
commented
Apr 27, 2024
| return False | ||
| self.log_info(f'Retrieving sos report from {self.address}') | ||
| self.ui_msg('Retrieving sos report...') | ||
| if self.need_sudo or self.opts.become_root: |
There was a problem hiding this comment.
The reason why this was refactored was, where retrieve_sosreport() function is being used it already checks for self.sos_path, so the code under the else seemed redundant
|
This way, we can then enable it, so that future PRs we'll get errors for f-strings too. |
pmoravec
reviewed
May 3, 2024
| @@ -322,7 +323,7 @@ def _send_pexpect_password(self, index, result): | |||
| :type result: ``pexpect.spawn`` | |||
| """ | |||
| if index == 2: | |||
| if not self.opts.sudo_pw and not self.opt.nopasswd_sudo: | |||
| if not self.opts.sudo_pw and not self.opts.nopasswd_sudo: | |||
There was a problem hiding this comment.
I didn't catch it, pylint did
pmoravec
reviewed
May 3, 2024
| self.all_pkgs_by_name_regex("fedora-release-.*")[-1] | ||
| self.package_manager.all_pkgs_by_name_regex( | ||
| "fedora-release-.*")[-1] |
There was a problem hiding this comment.
How this could even work now..? good catch.
There was a problem hiding this comment.
I didn't catch it, pylint did
pmoravec
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint for the following rules applied
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines