[apparmor] Capture AppArmor profiles and status #538
Conversation
|
Word wrapping in the commit message seems a bit odd - 72 chars hard wrap is recommended (the lines currently get longer down the message body.. :-). Ack modulo that & the add_cmd_output change. |
|
ACK once those changes are made |
Captures /etc/apparmor.d for profiles Excludes /cache - because it's not config. Excludes libvirt/libvirt because it can grow quite large and the TEMPLATE file should usually be enough. Excludes abstractions because they are usually not modified and are large. For both libvirt and abstractions capture an ls just to be sure permissions are correct. Captures apparmor_status to get the effective profiles. Signed-off-by: Bryan Quigley <bryan.quigley@canonical.com>
|
Hmm am I missing where the suggested changes were made in the commit? @BryanQuigley what's the status of this PR? |
|
odd, it looks like by force pushing we lost the previous "code" comments. The current 6e4c85c should have everything.. (note the longer lines and use of add_cmd_output([ ) |
|
@BryanQuigley cool thanks I thought this PR was missing something and I'm not going crazy :) |
|
ack on my end, @bmr-cymru this still look OK to you? |
|
Yeah - there seem to be bugs in the github force push handling. We noticed it earlier in the week with one of the Red Hat PRs - your initial comments remained under a "battlemidget commented on an outdated version of this patch" but my later review comments all vanished when the branch was re-pushed. Not sure if this relates to PR vs. commit/line comments or something else. |
|
Yep, looks good to me - thanks! |
Captures /etc/apparmor.d for profiles
Excludes /cache - because it's not config
Excludes libvirt/libvirt because it can grow
quite large and the TEMPLATE file should usually
be enough.
Excludes abstractions because they are usually
not modified by user and are quite big
For both libvirt and abstractions capture an ls,
just to be sure permissions, etc aren't messed up.
Captures apparmor_status to get the effective profiles.
Signed-off-by: Bryan Quigley bryan.quigley@canonical.com