Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mahjong] Add visualizer #976

Merged
merged 10 commits into from
Jul 4, 2023
Merged

[Mahjong] Add visualizer #976

merged 10 commits into from
Jul 4, 2023

Conversation

OkanoShinri
Copy link
Collaborator

No description provided.

@OkanoShinri
Copy link
Collaborator Author

OkanoShinri commented Jun 28, 2023

途中

temp

残り

  • カン
    - [ ] リーチ横向き
    - [ ] ツモ一番右に
    - [ ] 鳴かれた牌半透明
    - [ ] 中央の情報

@OkanoShinri
Copy link
Collaborator Author

png化もうまく行けてそうです!

temp(1)

@OkanoShinri
Copy link
Collaborator Author

MINKANしたときに手牌が減らないバグで沼ってました
なんか

hand=state.hand.at[].set(...)
hand=hand.at[].set(...)
state=state.relpace(hand=hand)

と一気に2回やるとうまく行かなくて、

hand=state.hand.at[].set(...)
state=state.relpace(hand=hand)
hand=state.hand.at[].set(...)
state=state.relpace(hand=hand)

と分けるとうまく行く。。。謎です

@sotetsuk
Copy link
Owner

sotetsuk commented Jul 4, 2023

@OkanoShinri これどうします?マージします? 👀

@sotetsuk sotetsuk changed the title [Mahjong] Add Visualizer [Mahjong] Add visualizer Jul 4, 2023
@OkanoShinri
Copy link
Collaborator Author

@OkanoShinri これどうします?マージします? 👀

Todoはissueに退避してあるので、このPRはマージ可能です👍
手牌と河は可視化できているので、最低限のデバッグはサポートできます

@OkanoShinri
Copy link
Collaborator Author

temp

@sotetsuk
Copy link
Owner

sotetsuk commented Jul 4, 2023

じゃあマージしちゃってください!🙏@OkanoShinri

@OkanoShinri OkanoShinri merged commit 8fb713f into main Jul 4, 2023
4 checks passed
@OkanoShinri OkanoShinri deleted the okano/feat/mahjong-vis branch July 4, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants