Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AWSHTTPClient protocol #518

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Conversation

adam-fowler
Copy link
Member

It is only used internally and has no real use anymore. Plus it was causing a warning because of Sendable conformance issues

It is only used internally and has no real use anymore. Plus it was causing a warning because of Sendable conformance issues
@adam-fowler adam-fowler requested a review from 0xTim October 4, 2022 08:33
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #518 (1d5c443) into main (87d80c1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   72.47%   72.46%   -0.01%     
==========================================
  Files          78       78              
  Lines        6136     6134       -2     
==========================================
- Hits         4447     4445       -2     
  Misses       1689     1689              
Impacted Files Coverage Δ
Sources/SotoCore/HTTP/AWSHTTPTypes.swift 100.00% <ø> (ø)
...toCore/Credential/MetaDataCredentialProvider.swift 89.47% <100.00%> (ø)
Sources/SotoCore/HTTP/AsyncHTTPClient.swift 88.00% <100.00%> (ø)
...toCore/Credential/CredentialProviderSelector.swift 86.66% <0.00%> (-13.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adam-fowler adam-fowler merged commit addcfe6 into main Oct 4, 2022
@adam-fowler adam-fowler deleted the fix/remove-aws-http-client-protocol branch October 4, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants