Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Selected scenarios w better valuation score and split into train / test #20

Closed
sharonwx54 opened this issue Oct 1, 2023 · 3 comments · Fixed by #25
Closed
Assignees
Labels
data-process Something related to sotopia data enhancement New feature or request help wanted Extra attention is needed

Comments

@sharonwx54
Copy link
Collaborator

Description

Adding filtering layer to select dialogue/scenario that produces high overall score.

Additional Information

No response

@sharonwx54 sharonwx54 added the enhancement New feature or request label Oct 1, 2023
@sharonwx54 sharonwx54 self-assigned this Oct 1, 2023
@lwaekfjlk
Copy link
Member

@ProKil @XuhuiZhou Do we have designed scenario or dialogue filtering strategy? I remember that you mentioned using distribution and variance for selection.

@lwaekfjlk lwaekfjlk added help wanted Extra attention is needed data-process Something related to sotopia data labels Oct 2, 2023
@XuhuiZhou
Copy link

@lwaekfjlk Yeah, that's more for selecting challenging scenarios. I don't think we have a filtering strategy for quality (if this is what you are asking for?) cuz we manually get rid of those scenarios that are not natural.

@sharonwx54
Copy link
Collaborator Author

Preliminary split by scenario, filtering by overall score, and selection of 2agent dialogues sit in the branch https://github.com/XuhuiZhou/sotopia/tree/feature/log-filtering-for-ft. Currently we are using 3.2 as a threshold value for dropping low performance dialogues, and the value is the overall reward values, not corresponding to any specific metrics such as believability or secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-process Something related to sotopia data enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants