Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wgpu-rs 0.5. #21

Closed
StarArawn opened this issue Apr 8, 2020 · 11 comments · Fixed by #29
Closed

Update to wgpu-rs 0.5. #21

StarArawn opened this issue Apr 8, 2020 · 11 comments · Fixed by #29

Comments

@StarArawn
Copy link

StarArawn commented Apr 8, 2020

Like the title says.

@Phaiax
Copy link

Phaiax commented Apr 8, 2020

CullMode must be wgpu::CullMode::None in tutorial 3 with wgpu-rs 0.5

@tasgon
Copy link

tasgon commented Apr 9, 2020

Also, for the swapchain tutorial, wgpu::Adapter::{request, request_device} is async now, so you'll likely need futures

@Phaiax
Copy link

Phaiax commented Apr 10, 2020

CullMode must be wgpu::CullMode::None in tutorial 3 with wgpu-rs 0.5

Oh my innocent past self 😄
Not that I know what CullMode is, I can say that the y axis direction has changed. (That means that my triangle was upside-down but i did not notice that^^. But it looks much cooler that way, anyway.)

Still innocent regards, Daniel

@sotrh
Copy link
Owner

sotrh commented Apr 19, 2020

I'm in process of updating. It might take awhile.

@shika-blyat
Copy link
Contributor

I'd like to help, but i don't want to do the work twice, could you list tutorials you already updated, tutorials you're still working on and tutorials that i (and other potential contributors) could update ?

@Cupnfish
Copy link

I wanted to update it before,but there's a bug in the wgpu document.

@shika-blyat
Copy link
Contributor

the bug is now fixed, you can build the doc locally, even if it doesn't work on crates.io doc instance yet

@Cupnfish
Copy link

Ok,I see that @sotrh has started writing a branch called 0.5.
In order not to overlap with his work, I started upgrading the Wgpu from the latter part.

@sotrh
Copy link
Owner

sotrh commented Apr 22, 2020

I merged you're changes @YRainbbbb. I'm working on tutorial 6 (the camera/uniforms one) currently

@sotrh
Copy link
Owner

sotrh commented Apr 25, 2020

I'm going to make a final pass through the main tutorial code. If any one wants to help with the migration, the showcase folder is still needs to be updated.

@sotrh
Copy link
Owner

sotrh commented Apr 25, 2020

Be aware that I'm using wgpu = 0.5.0. Using the GitHub url might be more up to date, but it provides an inconsistent experience for readers as the version currently on the wgpu repo might differ from the code in the tutorials. Given how how often the code has been changed, I feel it's best to lock the tutorial down to the latest stable version.

@sotrh sotrh mentioned this issue Apr 26, 2020
Merged
@sotrh sotrh closed this as completed in #29 Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants