Cleanup nov2020 #126
Merged
Cleanup nov2020 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have broadly made two sets of changes: 1. General prose cleanup (eg. correcting minor syntax errors, rewriting some sentences to make them more clear) 2. Code consistency (eg. not making use of the `texture` wrapper until it is defined at the end of the page.
1. The fields ` diffuse_texture`, `diffuse_texture_view` and `diffuse_sampler` are not used on `State` in this tutorial and should therefore not be added, so as not to unnecessarily confuse the reader. 2. The `anyhow` crate must be added to `Cargo.toml` in order for `texture.rs` to work.
1. The fields ` diffuse_texture`, `diffuse_texture_view` and `diffuse_sampler` are not used on `State` in this tutorial and should therefore not be added, so as not to unnecessarily confuse the reader. 2. The `anyhow` crate must be added to `Cargo.toml` in order for `texture.rs` to work.
- Add `diffuse_texture` to `texture::Texture` in `State` at the end of the tutorial.
Cleanup Textures tutorial
This was referenced Nov 24, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122