Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer to peer code review #5

Open
brahimdidi opened this issue Feb 24, 2022 · 1 comment
Open

Peer to peer code review #5

brahimdidi opened this issue Feb 24, 2022 · 1 comment

Comments

@brahimdidi
Copy link

brahimdidi commented Feb 24, 2022

Hello Ismail and souad, great work on your project however we would like to point out some points.

  • You did not follow the AAA (arrange, act, assert), It would be better if you implement that.
  • On this line
    test('tasks length to be 1', () => {

    the title is wrong.
  • The index.test.js file is not testing the dom manipulation
@ahangarha
Copy link

I also wanted to ask why you implemented localStorage mock? The the project specification it was said we need to mock localStorage on Ject version 25 and below. No?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants