Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize symbol table in SymbolTable.h #45

Closed
b-scholz opened this issue Apr 1, 2016 · 0 comments
Closed

Optimize symbol table in SymbolTable.h #45

b-scholz opened this issue Apr 1, 2016 · 0 comments
Labels
enhancement
Milestone
1.1

Comments

@b-scholz
Copy link
Member

b-scholz commented Apr 1, 2016

The symbol table does not use a hash-map and hence is inefficient. In addition, strings are copied rather than referred to. This causes another inefficiency. Hence, when loading large data from files, the symbol table becomes a bottle neck.
@kavorobyov kavorobyov modified the milestone: 0.0.2 Apr 23, 2016
@b-scholz b-scholz modified the milestones: 1.1.0, 0.0.2 Apr 26, 2016
b-scholz added a commit that referenced this issue Nov 29, 2016
@b-scholz
Merge pull request #242 from lyndonhenry/master
c88dc18 
Issue #45: Solved, but still perhaps room for improvement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@kavorobyov @b-scholz