Added limitsize directive #1599
Conversation
src/ram/RelationSize.h
Outdated
| @@ -0,0 +1,79 @@ | |||
| /* | |||
| * Souffle - A Datalog Compiler | |||
| * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights reserved | |||
src/ram/RelationSize.h
Outdated
| #pragma once | ||
|
|
||
| #include "ram/Expression.h" | ||
| #include "ram/NodeMapper.h" |
There was a problem hiding this comment.
It doesn't look like all these includes are needed. Remove the unused ones.
src/parser/parser.yy
Outdated
| @@ -884,6 +885,7 @@ io_head_decl | |||
| : INPUT_DECL { $$ = AstIoType::input; } | |||
| | OUTPUT_DECL { $$ = AstIoType::output; } | |||
| | PRINTSIZE_DECL { $$ = AstIoType::printsize; } | |||
| | LIMITSIZE_DECL { $$ = AstIoType::limitsize; } | |||
There was a problem hiding this comment.
This does not seem to be at all related to I/O. Could it instead be a new AST type?
There was a problem hiding this comment.
Longterm we should rename io-directives to relation-directives.
The reason is that we should not build two different directive infrastructures, i.e., one for IO and the other one for computation like limitsize.
src/parser/ParserDriver.cpp
Outdated
| @@ -137,6 +137,18 @@ void ParserDriver::addIO(std::unique_ptr<AstIO> d) { | |||
| return; | |||
| } | |||
| } | |||
| } else if (d->getType() == AstIoType::limitsize) { | |||
There was a problem hiding this comment.
d? This should be refactored to be a useful name. This can wait for another PR, though, since it was not introduced by this PR.
There was a problem hiding this comment.
Indeed - this should be directive.
Codecov Report
@@ Coverage Diff @@
## master #1599 +/- ##
==========================================
- Coverage 70.36% 70.34% -0.02%
==========================================
Files 219 220 +1
Lines 12163 12176 +13
==========================================
+ Hits 8558 8565 +7
- Misses 3605 3611 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I have renamed IO Directives to directives for most of the ast. In future, we can use the directive mechanism for other aspects including data-structure representations etc. |
This is a very basic implementation for the
limitsizedirective that stops evaluating a stratum when one or more of the specified relation have reached their specified cardinalities in thelimitsizedirective. Note thatlimitsizeis a very rough measure and is mainly useful for debugging purposes. This is related to issue #637.The syntax of the limitsize is
Here is an example,
that terminates the evaluation when A reaches the cardinality of 47.