Fix#2257 #2267
Merged
Fix#2257 #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that we could make the magic-set transformation more nuanced for eqrels but that requires quite some effort. It is more robust to replace them by b-tree relations. |
Codecov Report
@@ Coverage Diff @@
## master #2267 +/- ##
==========================================
+ Coverage 75.06% 76.95% +1.89%
==========================================
Files 455 455
Lines 28495 28496 +1
==========================================
+ Hits 21390 21930 +540
+ Misses 7105 6566 -539
|
SamArch27
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix to correct the magic-set pipeline. The pipeline is only executed, if a magic-set transformation is issued by the user either via command-line or via a pragma statement.
Note that magic-set transformations requires explicit rules for reflexivity, symmetry and transitivity and hence equivalence relations when used in conjunction with magic-set transformations must be transformed to btree relations.