eqrel: Simplify insertAll #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langston-barrett
force-pushed
the
lb/eqrel-insertall
branch
from
bf98599
to
6e1dd51
Compare
This loop isn't parallel, so there's no reason to use getChunks. Also, use modern C++ for-each loops and structured bindings.
langston-barrett
force-pushed
the
lb/eqrel-insertall
branch
from
6e1dd51
to
0ebb75f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2268 +/- ##
==========================================
- Coverage 76.95% 76.94% -0.02%
==========================================
Files 455 455
Lines 28496 28496
==========================================
- Hits 21930 21926 -4
- Misses 6566 6570 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loop isn't parallel, so there's no reason to use getChunks. Also, use modern C++ for-each loops and structured bindings.
Refactorings suggested by @OlivierHamel.