Support literal newlines in csv #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using pop_back is much more efficient to remove the trailing CR from a string.
Using a function to read the next line simplifies the mainloop a little bit and sets us up for supporting newlines in CSV cells.
According to rfc4180 newlines are allowed in CSV cells, provided they are enclosed in double quotes. Read another line if we encounter a newline character in a CSV cell. If cell contains CRLF, we reproduce CRLF in the text for the cell.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2329 +/- ##
==========================================
- Coverage 77.43% 77.41% -0.02%
==========================================
Files 468 468
Lines 29162 29177 +15
==========================================
+ Hits 22581 22588 +7
- Misses 6581 6589 +8
|
quentin
approved these changes
Oct 22, 2022
|
Thanks. This helps a lot. We'll probably have more commits like this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC4180, newlines should be supported provided they are quoted.
In RFC4180 mode, if a LF or CRLF sequence is found in a double-quoted cell, then the sequence is copied into the text for the cell.