Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typecheck error on atom negation with equivalent type #2399

Merged
merged 4 commits into from Feb 22, 2023

Conversation

Gueckmooh
Copy link
Contributor

When type checking atom negation, equivalent types were not taken into account. Now they are.
I've added the reproduction test in tests/syntactic/equivalent_types_in_negation/equivalent_types_in_negation.dl.

Fixes #2398

@Gueckmooh
Copy link
Contributor Author

Locally I have some tests that fails but it looks like it comes from my gcc distribution:

The following tests FAILED:
        2805 - syntactic/cpp_keywords_run_souffle (Failed)
        2806 - syntactic/cpp_keywords_compare_std_outputs (Not Run)
        2807 - syntactic/cpp_keywords_compare_csv (Not Run)
        2809 - syntactic/cpp_keywords_c_run_souffle (Failed)
        2810 - syntactic/cpp_keywords_c_compare_std_outputs (Not Run)
        2811 - syntactic/cpp_keywords_c_compare_csv (Not Run)

The tests are failing due to preprocessing errors on _Pragma. I suppose I don't have anything to do, but let me know if it looks weird.

Copy link
Member

@quentin quentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. This fix deserves to be part of 2.4 release that is coming soon.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #2399 (96768ad) into master (0334b07) will increase coverage by 0.08%.
The diff coverage is 85.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2399      +/-   ##
==========================================
+ Coverage   77.56%   77.64%   +0.08%     
==========================================
  Files         467      472       +5     
  Lines       30785    31042     +257     
==========================================
+ Hits        23877    24102     +225     
- Misses       6908     6940      +32     
Impacted Files Coverage Δ
src/parser/ParserDriver.h 100.00% <ø> (ø)
src/synthesiser/Synthesiser.h 100.00% <ø> (ø)
.../ast/transform/SimplifyConstantBinaryConstraints.h 50.00% <50.00%> (ø)
src/MainDriver.cpp 70.39% <70.27%> (+0.15%) ⬆️
src/parser/scanner.ll 78.01% <76.92%> (+5.49%) ⬆️
tests/libsouffle_interface/vfs_overlay_test.cpp 85.93% <85.93%> (ø)
src/parser/SrcLocation.cpp 91.86% <87.50%> (+7.24%) ⬆️
src/parser/ParserDriver.cpp 89.44% <88.33%> (-0.39%) ⬇️
src/parser/VirtualFileSystem.cpp 88.37% <88.37%> (ø)
...st/transform/SimplifyConstantBinaryConstraints.cpp 100.00% <100.00%> (ø)
... and 11 more

@quentin quentin merged commit 8aae521 into souffle-lang:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected type error when aliasing record type
2 participants