Misc Refactoring/Improvements #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 25, 2017 17:13
… to improve runtime for hmmer test by 0.06ms.
ghost
mentioned this pull request
|
This is going to fail the style tests for several files. clang-format changed behaviour between 3.8 and 3.9 (I think you could call it a bugfix) It looks like you're using clang-format-4.0 or so, but the check uses 3.8. I suggest you remove all the files where you are only changing style. They can be updated when the style checker is updated. That will be done when it looks like clang-format-3.9+ is more common. |
|
Ahh, ok. Thank you, that probably just saved me an evening of torture. I'll fix it up and push the changes. |
mmcgr
reviewed
May 25, 2017
src/PrecedenceGraph.h
Outdated
|
|
||
| public: | ||
| static constexpr const char* name = "scc-graph"; | ||
|
|
||
| void run(const AstTranslationUnit& translationUnit) override; | ||
|
|
||
| int getSCCForRelation(const AstRelation* relation) { | ||
| return nodeToSCC[relation]; | ||
| const unsigned getSCCForRelation(const AstRelation* relation) const { |
There was a problem hiding this comment.
Do these non-reference returns really need to return a const?
There was a problem hiding this comment.
No there is no reason for them to do that and I shall change it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request bundles a bunch of very small changes, each too minor to justify its own pull request but taken as a whole too major to simply bundle with another.
They include: