Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto download missing fixer #10

Open
soullivaneuh opened this issue Sep 24, 2015 · 10 comments
Open

Auto download missing fixer #10

soullivaneuh opened this issue Sep 24, 2015 · 10 comments
Assignees

Comments

@soullivaneuh
Copy link
Owner

Create a command to auto download missing fixer between PHP-CS-Fixer stable, on StyleCI/master fork.

Related to #6 (comment).

@GrahamCampbell
Copy link

That won't work, because the fixer interface in 2.x might change from what it was in 1.x.

@GrahamCampbell
Copy link

And, actually, some stuff has changed internally in 2.x too, and more will change in the future too.

@GrahamCampbell
Copy link

The safest option is probably to actually just use StyleCI's php-cs-fixer fork.

@GrahamCampbell
Copy link

I'll be tagging v1.0.0 on there soon, so you shouldn't have to worry about me messing with the master branch anymore.

@GrahamCampbell
Copy link

I published it on packagist to make it easier to use.

@soullivaneuh
Copy link
Owner Author

That won't work, because the fixer interface in 2.x might change from what it was in 1.x.
And, actually, some stuff has changed internally in 2.x too, and more will change in the future too.

Yeah I think I'll have difficulties too. This is just a issue for now, we will see that later. 👍

I'll be tagging v1.0.0 on there soon, so you shouldn't have to worry about me messing with the master branch anymore.
I published it on packagist to make it easier to use.

I'm not sure of what you are talking. You published your fixer for php-cs-fixer 1.x?

@soullivaneuh
Copy link
Owner Author

I saw your repository: https://github.com/StyleCI/PHP-CS-Fixer

I'm asking the same questions: Why not just a repository with only your custom fixers with php-cs-fixer dependencies? This will permit to integrate it on this library with ease for example.

With this, I have to in any case parse fixers directories to manually get yours.

@soullivaneuh
Copy link
Owner Author

And BTW, a same php support as official version for this one would be great. Otherwise, I can't link your library.

@soullivaneuh
Copy link
Owner Author

ping @GrahamCampbell

What do you think about #10 (comment)?

@soullivaneuh
Copy link
Owner Author

StyleCI/PHP-CS-Fixer repository does not exist anymore.

@GrahamCampbell Any chance to have your custom fixer? Tell me if absolutely not, I'll close the issue in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants