Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load fixers from StyleCI config instead of PHP-CS-Fixer #9

Merged
merged 1 commit into from
Sep 24, 2015

Conversation

soullivaneuh
Copy link
Owner

No description provided.

@soullivaneuh soullivaneuh self-assigned this Sep 24, 2015
@soullivaneuh soullivaneuh force-pushed the styleci-presets branch 5 times, most recently from ed75303 to 04d5eec Compare September 24, 2015 14:10
soullivaneuh added a commit that referenced this pull request Sep 24, 2015
Load fixers from StyleCI config instead of PHP-CS-Fixer
@soullivaneuh soullivaneuh merged commit 4303b2d into master Sep 24, 2015
@soullivaneuh soullivaneuh deleted the styleci-presets branch September 24, 2015 14:18
This was referenced Sep 24, 2015
@GrahamCampbell
Copy link

Note that the fixer names match that of 2.0, not 1.x. There are some differences.

@GrahamCampbell
Copy link

For example, phpdoc_align is named phpdoc_params in 1.x.

@GrahamCampbell
Copy link

Oh, yeh, I see you copied the aliases stuff over. :)

@GrahamCampbell
Copy link

You'll need to work the aliases backwards to be compatible with 1.x.


finder:
not-name:
- "*.php.twig"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be excluded by default anyway, because it doesn't match "*.php", it's "*.php*".

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was I thinking. But no, php-cs-fixer with default config was trying to fix my .php.twig...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. Ok then. :)

@soullivaneuh
Copy link
Owner Author

Note that the fixer names match that of 2.0, not 1.x. There are some differences.

For aliases and missing fixers, this is planned on #10 and #13.

I just made a quick fix to make this bridge more compliant with StyleCI.

And yeah, we have Laravel preset now. \o/ ;-)

@GrahamCampbell
Copy link

:)

@GrahamCampbell
Copy link

Can I chat to you on slack or something?

@GrahamCampbell
Copy link

Or skype. Got some things I want to discuss with you. :)

@soullivaneuh
Copy link
Owner Author

The best for me is to contact me by mail at soullivaneuh(at)gmail.com. 👍

You can also add me at hangout if you want direct chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants