-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load fixers from StyleCI config instead of PHP-CS-Fixer #9
Conversation
ed75303
to
04d5eec
Compare
04d5eec
to
5f8dc5f
Compare
Load fixers from StyleCI config instead of PHP-CS-Fixer
Note that the fixer names match that of 2.0, not 1.x. There are some differences. |
For example, phpdoc_align is named phpdoc_params in 1.x. |
Oh, yeh, I see you copied the aliases stuff over. :) |
You'll need to work the aliases backwards to be compatible with 1.x. |
|
||
finder: | ||
not-name: | ||
- "*.php.twig" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that be excluded by default anyway, because it doesn't match "*.php"
, it's "*.php*"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was I thinking. But no, php-cs-fixer with default config was trying to fix my .php.twig
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm. Ok then. :)
:) |
Can I chat to you on slack or something? |
Or skype. Got some things I want to discuss with you. :) |
The best for me is to contact me by mail at You can also add me at hangout if you want direct chat. |
No description provided.