Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some known issues and code cleanups in v1.3.2 #80

Closed
soundar24 opened this issue Apr 28, 2018 · 1 comment
Closed

Some known issues and code cleanups in v1.3.2 #80

soundar24 opened this issue Apr 28, 2018 · 1 comment
Milestone
v1.3.3

Comments

@soundar24
Copy link
Owner

soundar24 commented Apr 28, 2018 •
edited
Loading

  1. In v1.3.2, added the browser name in the root element but it was mistakenly added as "ie" in the chrome browser.
    Seems, in the fiddle sample of chrome the browser name appended as "ie". So once need to confirm this:
    http://jsfiddle.net/soundar24/s5gpugjn/4/

  2. Code clean-up

  3. Change event flow changes - when continuously pressing the UP arrow the change event triggers continuously. But, instead of that, drag event should be triggered and when the keyup happens at that time only change event should be triggered.
    This will be avoid the performance issues when we do any operation in the change event.
@soundar24 soundar24 added this to the v1.3.3 milestone Apr 28, 2018
@soundar24 soundar24 mentioned this issue Apr 28, 2018
Closed
soundar24 added a commit that referenced this issue Apr 28, 2018
@soundar24
#80 - browser name issue resolved
b572a4f
@soundar24 soundar24 changed the title Some known issues and corrections in v1.3.2 Some known issues and code cleanups in v1.3.2 Apr 30, 2018
soundar24 added a commit that referenced this issue Apr 30, 2018
@soundar24
#80 - code clean-up
441b467
soundar24 added a commit that referenced this issue Jan 7, 2019
@soundar24
#80 - Change event flow changes - Now continuous UP arrow press consi…
5f236f5 
…dered as drag and final only change event.
@soundar24
Copy link
Owner Author

resolved, so closed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.3
Development

No branches or pull requests
1 participant
@soundar24