Support elements - <b>, <strong>, <i>, <em>, <del> and <code> #36

Open
wants to merge 2 commits into
from

Projects

None yet

3 participants

@r-a-y
r-a-y commented May 5, 2016 edited

Hi Jevon,

Nice library! I've been using it in a few projects.

Here's a PR that supports a few other elements:

  • <strong> uses two asterisks.
  • <em> uses one underscore. Could use the asterisk instead, but thought it might be harder to see when <strong> is in use.
  • <del> uses the Github Markdown syntax of two tildes.
  • <code> uses the ` character.
@r-a-y r-a-y changed the title from Support elements - <b>, <strong>, <i>, <em> and <del> to Support elements - <b>, <strong>, <i>, <em>, <del> and <code> May 5, 2016
@soundasleep
Owner

Hello - I like the idea of this change! Can you add some tests that test each of these new elements?

https://github.com/soundasleep/html2text/tree/master/tests

@jaylinski
Contributor
jaylinski commented Nov 25, 2016 edited

Isn't this what html-to-markdown does?

https://github.com/thephpleague/html-to-markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment