Html2Text.convert() fixed against non-string input, version 0.2.1 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpithart
force-pushed
the
resiliency-against-non-string
branch
3 times, most recently
from
42587e8
to
08b2873
Compare
|
Thank you for the PR! It looks like there's something broken with the build at the moment, but it's unrelated to your change, so happy to merge this in. |
|
So let me please know when 0.2.1 makes it into rubygems.org so I can use it as dependency in my project's Gemfile. |
|
I've fixed the build (travis-ci issue) and have deployed 0.2.1 to rubygems. Thank you! |
gendosu
added a commit
to pocake/html2text_ruby
that referenced
this pull request
Apr 25, 2023
update nokogiri v1.14.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves how the library behaves on non-string input. Fixes issue #2.
Version number is increased to 0.2.1 according semver, as I consider this a bugfix.