Strip zero width non joiners #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. @soundasleep any chance you could take a look / merge this for us? |
|
Thank you for your contribution & tests! Happy to merge this in :) |
soundasleep
added a commit
to soundasleep/html2text
that referenced
this pull request
Feb 15, 2019
Based on feature request in html2text_ruby: soundasleep/html2text_ruby#5
gendosu
added a commit
to pocake/html2text_ruby
that referenced
this pull request
Apr 25, 2023
forgetting Gemfile.lock commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently zero-width non-joiners appear as spaces when converted by
html2text. This change strips them, which is closer to how they should ideally be displayed.