-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding loader for DCASE'23 Task 6A/6B #143
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 98.78% 98.85% +0.06%
==========================================
Files 31 33 +2
Lines 2640 2800 +160
==========================================
+ Hits 2608 2768 +160
Misses 32 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, also the new download and extract 7z files functions. Dataloader docstring needs revision since it is not rendering properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some minor changes. 🙏🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last super minor change and ready to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge!
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/
, e.g.make_my_dataset_index.py
, which generates an index file.soundata/indexes/
e.g.my_dataset_index.json
.soundata/my_dataset.py
.tests/
, e.g.test_my_dataset.py
.docs/source/soundata.rst
anddocs/source/quick_reference.rst
.black
,flake8
andmypy
(see Running your tests locally).tests/test_full_dataset.py
on your dataset.