Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding loader for DCASE'23 Task 6A/6B #143

Merged
merged 37 commits into from
Dec 1, 2023
Merged

Adding loader for DCASE'23 Task 6A/6B #143

merged 37 commits into from
Dec 1, 2023

Conversation

tanmayy24
Copy link
Collaborator

@tanmayy24 tanmayy24 commented Nov 29, 2023

Description

Please include the following information at the top level docstring for the dataset's module mydataset.py:

  • Describe annotations included in the dataset
  • Indicate the total duration of the dataset in hours, and (optionally) also list the number of individual files
  • Mention the origin of the dataset (e.g. creator, institution)
  • Describe the type of audio included in the dataset
  • Indicate any relevant papers related to the dataset
  • Include a description about how the data can be accessed and the license it uses (if applicable)

Dataset loaders checklist:

  • Create a script in scripts/, e.g. make_my_dataset_index.py, which generates an index file.
  • Run the script on the canonical version of the dataset and save the index in soundata/indexes/ e.g. my_dataset_index.json.
  • Create a module in soundata, e.g. soundata/my_dataset.py.
  • Create tests for your loader in tests/, e.g. test_my_dataset.py.
  • Add your module to docs/source/soundata.rst and docs/source/quick_reference.rst.
  • Run black, flake8 and mypy (see Running your tests locally).
  • Run tests/test_full_dataset.py on your dataset.
  • Check that codecov coverage does not decrease.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #143 (b2bc027) into main (8e7cb7a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   98.78%   98.85%   +0.06%     
==========================================
  Files          31       33       +2     
  Lines        2640     2800     +160     
==========================================
+ Hits         2608     2768     +160     
  Misses         32       32              

@tanmayy24 tanmayy24 changed the title [WIP] Adding loader for DCASE'23 Task 6B Adding loader for DCASE'23 Task 6B Nov 29, 2023
Copy link
Collaborator

@guillemcortes guillemcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also the new download and extract 7z files functions. Dataloader docstring needs revision since it is not rendering properly.

soundata/datasets/dcase23_task6b.py Outdated Show resolved Hide resolved
soundata/datasets/dcase23_task6b.py Outdated Show resolved Hide resolved
@tanmayy24 tanmayy24 changed the title Adding loader for DCASE'23 Task 6B Adding loader for DCASE'23 Task 6A/6B Dec 1, 2023
Copy link
Collaborator

@guillemcortes guillemcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some minor changes. 🙏🏼

soundata/datasets/dcase23_task6a.py Outdated Show resolved Hide resolved
soundata/datasets/dcase23_task6a.py Outdated Show resolved Hide resolved
soundata/datasets/dcase23_task6b.py Outdated Show resolved Hide resolved
soundata/datasets/dcase23_task6b.py Outdated Show resolved Hide resolved
soundata/download_utils.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@guillemcortes guillemcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last super minor change and ready to go!

.github/environment-ci.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@guillemcortes guillemcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

@tanmayy24 tanmayy24 merged commit d8d6f69 into main Dec 1, 2023
11 checks passed
@magdalenafuentes magdalenafuentes deleted the tanmay/dcase23_6b branch February 6, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants