Adding loader for DCASE'23 Task 6A #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## tanmay/dcase23_6b #144 +/- ##
=====================================================
+ Coverage 98.73% 98.76% +0.03%
=====================================================
Files 30 31 +1
Lines 2603 2677 +74
=====================================================
+ Hits 2570 2644 +74
Misses 33 33 |
guillemcortes
requested changes
Dec 1, 2023
There was a problem hiding this comment.
I see that you have included the changes of task6b into this PR, should we delete the #143, then? The comments here are the same there. Basically docstring, DictReader and change PARSER to parser
| file_path = os.path.join(self.data_home, file_name) | ||
| delimiter = ";" if file_type == "test_metadata" else "," | ||
| with open(file_path, encoding="ISO-8859-1") as csv_file: | ||
| csv_reader = csv.reader(csv_file, delimiter=delimiter) |
soundata/datasets/dcase23_task6b.py
Outdated
| file_path = os.path.join(self.data_home, file_name) | ||
| # Now open the file with the mentioned encoding | ||
| with open(file_path, encoding="ISO-8859-1") as csv_file: | ||
| csv_reader = csv.reader(csv_file, delimiter=",") |
soundata/datasets/dcase23_task6b.py
Outdated
| @@ -0,0 +1,349 @@ | |||
| """DCASE 2023 Task-6B Dataset Loader | |||
There was a problem hiding this comment.
Double check docstring
| @@ -0,0 +1,349 @@ | |||
| """DCASE 2023 Task-6A Dataset Loader | |||
There was a problem hiding this comment.
Double check docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/, e.g.make_my_dataset_index.py, which generates an index file.soundata/indexes/e.g.my_dataset_index.json.soundata/my_dataset.py.tests/, e.g.test_my_dataset.py.docs/source/soundata.rstanddocs/source/quick_reference.rst.black,flake8andmypy(see Running your tests locally).tests/test_full_dataset.pyon your dataset.