-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chunker requirements #114
Conversation
@hannestyden There are still some specs to fix, but I wanted to get this out early for review. |
1687817
to
262540b
Compare
While it's true that the chunker does not strictly require an auto_increment column, it's implemented on the assumption that the identifier column is monotonically increasing. AFAIK the chunker behaves quite poorly in case of huge gaps between rows. I'd suggest to add a note to the README explaining that a monotonically increasing counter is recommended / warning that a migration will be quite slow with column of different value distributions. |
The original version of LHM did not require The real issue is when the I can add a note about sparse |
33ba4ac
to
d22340b
Compare
@arthurnn @hannestyden Ok, all the tests pass. |
Ping, @hannestyden. 😄 |
@grobie How does this look to you now? |
d22340b
to
bd9942e
Compare
@@ -7,6 +7,7 @@ end | |||
``` | |||
* #98 - Add slave lag throttler. (@camilo, @jasonhl) | |||
* #92 - Fix check for table requirement before starting a lhm.(@hannestyden) | |||
* #114 - Update chunker requirements (@bjk-soundcloud) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is in the middle? (can you move it to the top? )
The chunker does not require an auto_increment column, it simply requires an integer column in order to find the start/limit of the table. Relax the migrator/table checks to only look for an `id` INT column. * Add support for BIGINT `id` columns * Add fixture for BIGINT `id` column * Add test for BIGINT `id` columns * Add fixture for "broken" varchar `id` column * Update specs * Update README with changes, and note about sparse `id` data
bd9942e
to
600c9f2
Compare
Looking good! 👍 |
👍 |
Update chunker requirements
The chunker does not require an auto_increment column, it simply
requires an integer column in order to find the start/limit of the
table.
Relax the migrator/table checks to only look for an
id
INT column.id
columnsid
columnid
column