update playback library #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you walk me through these changes? |
janmonschke
approved these changes
Nov 7, 2018
they no longer exist in the playback library, plus they would never be triggered before anyway. If a track is geoblocked the `SC.stream()` promise rejects, because the api returns a 403 at that point. We also always retry to retrieve urls on a connection timeout, whilst the player is not killed, so the 'no_connection' error would never be triggered
|
@axinja quite a lot has changed in scaudio since v12. If you want to see an overview you can check the documentation in the releases on the scaudio repo. There should be no change on the api that this sdk provides though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this updates scaudio from from v12.0.0 to v21.3.4
It also removes the
geoblockedandno_connectionerrors.They no longer exist in the playback library, plus they would never be triggered before anyway.
If a track is geoblocked the
SC.stream()promise rejects, because the api returns a 403 at that point.We also always retry to retrieve urls on a connection timeout, whilst the player is not killed, so the
no_connectionerror would never actually be triggered at the moment.