-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved types, using mintType instead of interfaceId #54
Conversation
🦋 Changeset detectedLatest commit: ffcc8fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still missing the type-guard helpers to not have to manually code them after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically we need helper that do isFixedPriceSignature(...)
isRangeEdition(...)
isMerkleDrop(...)
@PabloSzx , what kind of helpers are you thinking? |
|
Split the Configs and Schedules into subtypes and added typeguard mintType
e.g. MerkleDropSchedule and MerkleDropSchedule
and mintType = 'MerkleDrop' for use as a typeguard