Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question ID higher than the maximum question ID crashes Workspace #153

Closed
remo5000 opened this issue Jul 4, 2018 · 2 comments · Fixed by #173 or #178
Closed

Question ID higher than the maximum question ID crashes Workspace #153

remo5000 opened this issue Jul 4, 2018 · 2 comments · Fixed by #173 or #178
Labels
Bug Something isn't working

Comments

@remo5000
Copy link
Contributor

remo5000 commented Jul 4, 2018 •
edited

This is expected by design, just that it would be nice to account for this bug (in case some power user types in the exact question they want to do). A negative number doesn't get parsed into a number, so that side of the cases is taken care of.
@remo5000 remo5000 added the Bug Something isn't working label Jul 4, 2018
@remo5000
Copy link
Contributor Author

remo5000 commented Jul 4, 2018

This will have to be checked when Assessment or Grading is already fetched. However, the props cannot be modified when rendering.

A solution that is not anti-pattern would be to set questionId in the local state of the Component. This means that we can also make the default questionId 0 without using a truthy check!

remo5000 added a commit that referenced this issue Jul 6, 2018
@remo5000
Fix #153
24c3fba
@remo5000 remo5000 mentioned this issue Jul 6, 2018
Merged
remo5000 added a commit that referenced this issue Jul 6, 2018
@remo5000
Fix #153
0cccdba
remo5000 added a commit that referenced this issue Jul 6, 2018
@remo5000
Fix #153
ec2586b
ning-y pushed a commit that referenced this issue Jul 6, 2018
@remo5000 @ning-y
Fix workspace bugs (#173)
62f2d69 
* Fix #164

* Fix #153

* Fix #167

Adding this infinity prop is part of an update we do not have yet (ace
editor) fxmontigny/ng2-ace-editor#11

Used a fix for react I found here: securingsincity/react-ace#29

* Fix #172, #171, #168 using PureComponent

- Call scroll inside ReplInput instead of Repl
- Change components to PureComponents (thereby changing the update
condition)
- Remove throttle for onChange

Lack of unneccasry updates and proper scrolling mechanism fixed #168.

* Format files

* Update tests

* Move overflow to side-content-text

Also fixed a minor issue with padding disappearing, using fit-content.

* Remove text justification for markdown editor

I don't think markdown is justified, and so we shouln't be displaying it
in such a way either.

* Fix always-on scrollbars on X11

* Add overflow-y for card

* Fix side content header height

Also moved the css into the appropriate nested location.

* Format scss

* Bump version number 0.1.2 -> 0.1.3
@remo5000 remo5000 mentioned this issue Jul 6, 2018
Merged
@remo5000
Copy link
Contributor Author

remo5000 commented Jul 6, 2018

Not present for GradingWorkspace

@remo5000 remo5000 reopened this Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix workspace bugs source-academy/frontend
Change Submission Semantics source-academy/frontend
1 participant
@remo5000