Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key property needed by MCQChooser #164

Closed
remo5000 opened this issue Jul 5, 2018 · 0 comments · Fixed by #173
Closed

Key property needed by MCQChooser #164

remo5000 opened this issue Jul 5, 2018 · 0 comments · Fixed by #173
Labels
Bug Something isn't working

Comments

@remo5000
Copy link
Contributor

remo5000 commented Jul 5, 2018

Just need to use the key parameter in map()

@remo5000 remo5000 added the Bug Something isn't working label Jul 5, 2018
remo5000 added a commit that referenced this issue Jul 6, 2018
remo5000 added a commit that referenced this issue Jul 6, 2018
remo5000 added a commit that referenced this issue Jul 6, 2018
ning-y pushed a commit that referenced this issue Jul 6, 2018
* Fix #164

* Fix #153

* Fix #167

Adding this infinity prop is part of an update we do not have yet (ace
editor) fxmontigny/ng2-ace-editor#11

Used a fix for react I found here: securingsincity/react-ace#29

* Fix #172, #171, #168 using PureComponent

- Call scroll inside ReplInput instead of Repl
- Change components to PureComponents (thereby changing the update
condition)
- Remove throttle for onChange

Lack of unneccasry updates and proper scrolling mechanism fixed #168.

* Format files

* Update tests

* Move overflow to side-content-text

Also fixed a minor issue with padding disappearing, using fit-content.

* Remove text justification for markdown editor

I don't think markdown is justified, and so we shouln't be displaying it
in such a way either.

* Fix always-on scrollbars on X11

* Add overflow-y for card

* Fix side content header height

Also moved the css into the appropriate nested location.

* Format scss

* Bump version number 0.1.2 -> 0.1.3
Aulud pushed a commit to Aulud/cadet-frontend that referenced this issue May 25, 2020
* Add number, story, reading fields

* Address prelimiary comments

* Add grading library

* Add required true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant