Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chapter 3 support #35

Merged
merged 2 commits into from
Sep 22, 2018
Merged

Add Chapter 3 support #35

merged 2 commits into from
Sep 22, 2018

Conversation

remo5000
Copy link
Contributor

Features

  • Upgraded js-slang
  • Added chapter 3 tests

@coveralls
Copy link

Pull Request Test Coverage Report for Build 122

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 33.144%
Totals Coverage Status
Change from base Build 120: 0.2%
Covered Lines: 965
Relevant Lines: 2787
💛 - Coveralls

indocomsoft
indocomsoft approved these changes Sep 22, 2018
View reviewed changes
Copy link
Member

@indocomsoft indocomsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yyc
Copy link
Collaborator

yyc commented Sep 22, 2018 •
edited

Uhh you might want to hold off on this until after I add loop block scoping support (saves you a deployment).

Scratch that-let is already block scoped so ch3 should be correct.

@remo5000 remo5000 merged commit 304261e into master Sep 22, 2018
@remo5000 remo5000 deleted the chapter-three-support branch September 22, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indocomsoft indocomsoft indocomsoft approved these changes

@ning-y ning-y ning-y approved these changes

@yyc yyc Awaiting requested review from yyc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@remo5000 @coveralls @yyc @indocomsoft @ning-y